[PM-16183] Temporarily remove xcbeautify to troubleshoot hanging test runs#1275
Merged
[PM-16183] Temporarily remove xcbeautify to troubleshoot hanging test runs#1275
Conversation
vvolkgang
changed the title
fedemkr
approved these changes
Jan 15, 2025
Contributor
|
Great job, no security vulnerabilities found in this Pull Request |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1275 +/- ##
=======================================
Coverage 89.41% 89.41%
=======================================
Files 733 733
Lines 46253 46253
=======================================
Hits 41358 41358
Misses 4895 4895 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
PM-16183
📔 Objective
Some test runs are hanging until the runner reaches the timeout limit (e.g. https://github.com/bitwarden/ios/actions/runs/12776029096/). While troubleshooting it I noticed logs weren't correctly ordered, which is due to our testing suit running concurrently and us missing
NSUnbufferedIO=YES, per xcbeautify docs (ref.While setting that flag would help, for the time being we're temporarily removing xcbeautify until we figure what's causing tests to hang.
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes